π fix wrong ServiceRunGet model
#7349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## master #7349 +/- ##
==========================================
+ Coverage 85.58% 88.55% +2.96%
==========================================
Files 1705 1364 -341
Lines 66224 56577 -9647
Branches 1124 481 -643
==========================================
- Hits 56681 50099 -6582
+ Misses 9223 6346 -2877
+ Partials 320 132 -188
Continue to review full report in Codecov by Sentry.
π New features to boost your workflow:
|
matusdrobuliak66
requested review from
GitHK,
giancarloromeo,
pcrespov and
sanderegg
as code owners
matusdrobuliak66
added
the
a:webserver
pcrespov
approved these changes
Mar 12, 2025
packages/models-library/src/models_library/api_schemas_webserver/resource_usage.py
Show resolved
Hide resolved
packages/models-library/src/models_library/api_schemas_webserver/resource_usage.py
Show resolved
Hide resolved
GitHK
approved these changes
Mar 12, 2025
|
matusdrobuliak66
merged commit dfb4149
into
ITISFoundation:master
94 of 95 checks passed
mrnicegyu11
pushed a commit
to mrnicegyu11/osparc-simcore
that referenced
this pull request
Mar 26, 2025
Closed
56 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
In the previous PR β¨ Introduce wallet exchange ποΈΒ #7033 I refactored
But the model didn't have all the fields -> this is fixed in the PR
This was also partially hotfixed yesterday with this commit 6bc3d32
Related issue/s
How to test
Dev-ops checklist